Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 90.43% 84.92% -5.52%
==========================================
Files 5 5
Lines 251 325 +74
==========================================
+ Hits 227 276 +49
- Misses 24 49 +25
🚀 New features to boost your workflow:
|
gwynne
previously approved these changes
Nov 25, 2025
Member
gwynne
left a comment
gwynne
left a comment
There was a problem hiding this comment.
My nits are not particularly critical, not using them will not make a huge difference. It'd be interesting to know if they benchmarked differently though.
Comment on lines
+108
to
+118
| if let partials = currentNode.partials, !partials.isEmpty { | ||
| for partial in partials { | ||
| alternatives.append( | ||
| .init( | ||
| node: partial.node, | ||
| index: index, | ||
| kind: .partial(partial), | ||
| parameterSnapshot: parameters | ||
| )) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if let partials = currentNode.partials, !partials.isEmpty { | |
| for partial in partials { | |
| alternatives.append( | |
| .init( | |
| node: partial.node, | |
| index: index, | |
| kind: .partial(partial), | |
| parameterSnapshot: parameters | |
| )) | |
| } | |
| } | |
| alternatives.append(contentsOf: currentNode.partials?.map { .init( | |
| node: partial.node, index: index, kind: .partial(partial), parameterSnapshot: parameters | |
| ) } ?? []) |
Note
.append(contentsOf: []) and [].map(...) both compile to no-ops, so eliding the conditional does not degrade performance.
Comment on lines
+91
to
+101
| if let partials = currentNode.partials, !partials.isEmpty { | ||
| for partial in partials { | ||
| alternatives.append( | ||
| .init( | ||
| node: partial.node, | ||
| index: index, | ||
| kind: .partial(partial), | ||
| parameterSnapshot: parameters | ||
| )) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if let partials = currentNode.partials, !partials.isEmpty { | |
| for partial in partials { | |
| alternatives.append( | |
| .init( | |
| node: partial.node, | |
| index: index, | |
| kind: .partial(partial), | |
| parameterSnapshot: parameters | |
| )) | |
| } | |
| } | |
| alternatives.append(contentsOf: currentNode.partials?.map { .init( | |
| node: partial.node, index: index, kind: .partial(partial), parameterSnapshot: parameters | |
| ) } ?? []) |
Note
.append(contentsOf: []) and [].map(...) both compile to no-ops, so eliding the conditional does not degrade performance.
Benchmark Report for dda4c9b❓ Pull request has significant performance differences 📊 Click to expand comparison resultBenchmark check running at 2025-11-25 11:29:11 UTCReading thresholds from "Benchmarks/Thresholds/" Checking ["RouterPerformance:Case-sensitive", "RouterPerformance:Case-insensitive", "RouterPerformance:Case-insensitive_Match_First", "RouterPerformance:Case-insensitive_Match_Last", "RouterPerformance:Case-sensitive_Minimal", "RouterPerformance:Case-insensitive_Minimal", "RouterPerformance:Minimal_Early_Fail"]
The baseline 'Add backtracking' is WORSE than the defined thresholds. Click to expand benchmark resultBaseline 'Add backtracking'RouterPerformanceCase-insensitive
Case-insensitive_Match_First
Case-insensitive_Match_Last
Case-insensitive_Minimal
Case-sensitive
Case-sensitive_Minimal
Minimal_Early_Fail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145
This adds recursive backtracking to the trie algorithm. Unfortunately this will likely result in some performance loss when routing but we do want routes to be resolved correctly