Repository navigation
chore(control-plane): move tests out of src/ into tests/ - #1849
Closed
nicoloboschi wants to merge 1 commit into
Closed
nicoloboschi wants to merge 1 commit into
nicoloboschi wants to merge 1 commit into
Conversation
Vitest test files lived next to the modules they covered (src/**/*.test.ts), which mixes test code into the source tree that ships in the standalone build. Move them to a sibling tests/ directory mirroring the src/ layout and update the vitest include glob accordingly. Relative imports inside the moved files (./base-path, ./session, ./route, etc.) are switched to the existing @/ alias so the tests don't have to know their own depth. The messages test resolves its catalog dir relative to src/messages.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hindsight-control-plane/src/**/*.test.tsto a siblinghindsight-control-plane/tests/tree that mirrors the source layout. Keeps test code out of the directory that ships in the standalone build../base-path,./session,./route,./sdk-response) to the existing@/alias so tests don't have to track their own depth.vitest.config.tsinclude glob totests/**/*.test.ts.messages.test.tsresolves its catalog dir relative tosrc/messages/(the catalogs themselves are still source).Test plan
npx vitest run— all 5 files, 65 tests pass../scripts/hooks/lint.sh— clean.