Repository navigation
docs(docker): drop --rm, add --name + restart policy in run examples - #1927
Merged
Merged
Conversation
A single child segfault under load propagates through start-all.sh and exits the whole container; with the documented --rm run there was no recovery. Replace --rm with --name hindsight --restart unless-stopped in the documented server-run commands so a transient crash self-heals. Leaves the throwaway --rm --entrypoint sh model-inspection command in custom-models/README.md untouched. Refs #1918.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the resilience half of #1918. A single child segfault under load propagates through
start-all.sh's cleanup and exits the whole container; with the documenteddocker run --rminvocation there is no recovery, so a transient crash becomes indefinite downtime.Replaces
--rmwith--name hindsight --restart unless-stoppedin the documented server-run commands so a transient crash self-heals:README.mdhindsight-api-slim/README.md,hindsight-api/README.md(no--pull/-p 9999here — kept as-is)hindsight-docs/docs/developer/installation.md,hindsight-docs/docs/developer/api/quickstart.mdxskills/hindsight-docs/**— regenerated mirror (pre-commit hook), tracks the source editsLeft untouched: the throwaway
docker run --rm --entrypoint shmodel-inspection command indocker/docker-compose/custom-models/README.md(ephemeral;--rmis correct there), plus cookbook recipes, blog posts, and frozenversioned_docssnapshots.On the pydantic suggestion in the issue
Investigated the suggested
pydantic-corebump — it is not actionable today:pydantic-corepin at import time (SystemErrorif mismatched), so you can't just swap the core.pydantic 2.13.4hard-requirespydantic-core==2.46.4(the crashing build); the only release pairing with2.47.0is the alphapydantic 2.14.0a1.2.47.0fixes this specific concurrent-recall GPF.Also note the published image resolves pydantic fresh at build time (the Dockerfile copies only
pyproject.tomland runsuv syncwithout--frozen), so a lockfile pin wouldn't reach the image regardless. Deferred per maintainer decision; revisit when a stable pydantic pairs with a fixedpydantic-core.Note
With a fixed
--name hindsight, re-running the quickstart errors with "name in use" untildocker rm hindsight— the expected tradeoff for a stable name + restart policy on a single-instance deployment.Refs #1918