Repository navigation
feat/helm api command probe strategy - #5988
Merged
Merged
Conversation
…tServiceAccountToken Four optional api values, all unset by default, so the default render is byte-identical. Adds a lint-helm-chart render step that checks the default has none of them and each one renders when set. Closes #5843
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5843
Adds four optional values under
api, each unset by default:api.command— override the container command (e.g. wrap the server in a log filter)api.startupProbe— rendered only when set; liveness/readiness wait for itapi.strategy— e.g.{type: Recreate}for a single replica / RWO volumeapi.automountServiceAccountToken— rendered only when it is a booleanThe default
helm templateoutput is byte-identical to main. A newlint-helm-chartstep checks the default render has none of the four and that each renders when set.Tested on a real cluster (k3s via local-kubernetes-runner)
Installed the chart with all four set (image 1.1.0, LLM provider
none):strategy: Recreate,automountServiceAccountToken: false, the custom command and the startup probe./var/run/secrets/kubernetes.io/serviceaccountabsent).[wrapped]prefix);/healthhealthy.rollout restart: old ReplicaSet scaled to 0 before the new one scaled up; never more than one api pod at once.