fix(core): Persist scalar custom fields in updateGlobalSettings with relations#4368
Draft
biggamesmallworld wants to merge 1 commit intomasterfrom
Draft
fix(core): Persist scalar custom fields in updateGlobalSettings with relations#4368biggamesmallworld wants to merge 1 commit intomasterfrom
biggamesmallworld wants to merge 1 commit intomasterfrom
Conversation
…relations Save the entity to DB before calling updateRelations so that when updateRelations re-fetches the entity, it picks up the already-persisted scalar custom field values instead of stale DB values. Fixes #4342 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateGlobalSettingsmutation not persisting scalar custom field values when a relational custom field is also defined onGlobalSettingsupdateRelations(), matching the pattern used by other services (e.g.CollectionService,FacetService)Fixes #4342
Test plan
custom-field-relationse2e tests pass (59/59)global-settingse2e tests pass (7/7)🤖 Generated with Claude Code