Skip to content

Comments

fix(dashboard): add entity to DetailPage#4369

Open
LucidityDesign wants to merge 1 commit intovendurehq:minorfrom
LucidityDesign:context-entity
Open

fix(dashboard): add entity to DetailPage#4369
LucidityDesign wants to merge 1 commit intovendurehq:minorfrom
LucidityDesign:context-entity

Conversation

@LucidityDesign
Copy link

@LucidityDesign LucidityDesign commented Feb 17, 2026

Description

When adding a page block via defineDashboardExtension the context.entity is received from the page component. Without this change context.entity is undefined.

Breaking changes

None

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vendure-storybook Ready Ready Preview, Comment Feb 17, 2026 1:20pm

Request Review

@vendure-ci-automation-bot
Copy link
Contributor

vendure-ci-automation-bot bot commented Feb 17, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

📝 Walkthrough

Walkthrough

The change adds an entity prop to the Page component in the detail-page module. The Page component usage is updated to pass entity data as an additional parameter, making it accessible to downstream components in the component tree. This modification involves a single line addition and removal in the detail-page.tsx file.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title says 'fix' but the objectives indicate this is a feature addition, not a bug fix. The title itself accurately describes what was changed (adding entity to DetailPage), but the type prefix is incorrect. Change the title prefix from 'fix' to 'feat' to accurately reflect that this is a feature addition, not a bug fix: 'feat(dashboard): add entity to DetailPage'.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check ✅ Passed The PR description follows the template with clear summary, breaking changes section, and completed checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LucidityDesign
Copy link
Author

Sidenote: I have a special usecase where the create mutation returns more data than the get query. So it would be nice to have a way to skip the "get", because the create mutation already returns all the data that I need.

E.g.

mutation createApiKey {
   id
   ...
   unhashedKey
}

query apiKey {
   id
   ...
   # unhashedKey is only available during create
}

@LucidityDesign LucidityDesign changed the title feat: add entity to DetailPage fix: add entity to DetailPage Feb 17, 2026
@LucidityDesign
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@LucidityDesign LucidityDesign changed the base branch from master to minor February 17, 2026 13:16
@LucidityDesign LucidityDesign changed the title fix: add entity to DetailPage fix(dashboard): add entity to DetailPage Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant