Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lahfir
reviewed
Oct 31, 2026
| } | ||
| quiet_since = std::time::Instant::now(); | ||
| if state.resting { | ||
| bridge::show(); |
Collaborator
There was a problem hiding this comment.
press after the overlay rests brings the macOS cursor back. child.rs:93 wakes the overlay for the new caret-follow message too. The caret is already gone, so you get the cursor and bubble back with nothing drawn.
Fix: don't wake the overlay for that message.
ctate
force-pushed
the
ctate/overlay-caret-after-press
branch
from
October 31, 2026 02:08
9607cc3 to
8246a7b
Compare
ctate
force-pushed
the
ctate/overlay-caret-after-press
branch
from
October 31, 2026 03:49
8246a7b to
2f9b8a2
Compare
ctate
force-pushed
the
ctate/overlay-caret-after-press
branch
from
October 31, 2026 04:53
2f9b8a2 to
40f2c17
Compare
ctate
force-pushed
the
ctate/overlay-caret-after-press
branch
from
October 31, 2026 04:54
40f2c17 to
3dc6a60
Compare
lahfir
approved these changes
Oct 31, 2026
ctate
force-pushed
the
ctate/overlay-caret-after-press
branch
from
October 31, 2026 08:03
3dc6a60 to
7af1df8
Compare
- Move a caret that is showing to the focused text element's insertion point once `press` has delivered and the app has settled, or hide it when there is none - Add a caret-follow phase to the macOS and Windows renderers that moves or hides the caret, never shows one that is not showing, and leaves a rested overlay asleep - Skip the click ripple when `type` goes to a field that already has keyboard focus, from one focus read made only while the overlay is on
ctate
force-pushed
the
ctate/overlay-caret-after-press
branch
from
October 31, 2026 08:20
7af1df8 to
e159be5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
presshas delivered and the app has settled, or hide it when there is nonetypegoes to a field that already has keyboard focus, from one focus read made only while the overlay is onThe caret follows arrow keys, then typing resumes in the focused field with no second click.
caret-follows-keys.mp4