Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ctate
force-pushed
the
ctate/overlay-fill-follows-accent
branch
from
October 31, 2026 02:08
b1bdf9c to
7e34f93
Compare
ctate
marked this pull request as ready for review
October 31, 2026 02:20
ctate
force-pushed
the
ctate/overlay-fill-follows-accent
branch
2 times, most recently
from
October 31, 2026 04:53
5bfd3e4 to
66276e4
Compare
ctate
force-pushed
the
ctate/overlay-fill-follows-accent
branch
from
October 31, 2026 04:54
66276e4 to
301e20f
Compare
lahfir
self-requested a review
October 31, 2026 05:49
lahfir
approved these changes
Oct 31, 2026
lahfir
reviewed
Oct 31, 2026
| self.fill | ||
| .as_deref() | ||
| .and_then(rgb) | ||
| .unwrap_or_else(|| self.accent_rgb()) |
Collaborator
There was a problem hiding this comment.
this breaks the Linux live test at cursor_overlay_tests.rs:111, which still expects a white body.
fix: set_fill("#FFFFFF") on the style in that test so it still checks white and doesn't depend on the default.
ctate
force-pushed
the
ctate/overlay-fill-follows-accent
branch
from
October 31, 2026 08:03
301e20f to
79b1a1b
Compare
- Draw the cursor body in the accent colour by default, so one `--accent` colours the whole cursor - Keep `--fill` for a body colour other than the accent, and leave it out of the style when unset - Update the help, docs and skill that described a white default
ctate
force-pushed
the
ctate/overlay-fill-follows-accent
branch
from
October 31, 2026 08:20
79b1a1b to
1b90ed9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--accentcolours the whole cursor--fillfor a body colour other than the accent, and leave it out of the style when unsetBefore / after with only
--accentset.