Repository navigation
Conversation
Apps launched as login items can report an NSRunningApplication launchDate more than 5 s off the libproc process start. The global window inventory treated that offset as a generation change on every attempt, so list-windows and window screenshots retried until the deadline on a stable desktop. A launch-time disagreement now falls back to the live-instance check that owners without a launch date already use; a token whose process is gone still reports churn. The timeout dropped the pid and phase of the last churn error, so the failure surfaced only as an unresponsive-app hint. It now carries last_pid and last_phase. Fixes #374 Co-Authored-By: Prince Jain <117412569+princejain756@users.noreply.github.com>
A launch date outside the tolerance now falls back to a libproc read, so the existing churn test reached whatever process the host runs as pid 10. It now uses a pid macOS never assigns, so the live check finds no process and the test keeps asserting process_generation_changed on every machine.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list-windowsand window screenshots timed out on a stable desktop (fix(macos): verify live process instance when AppKit launch date is skewed #379).last_pidandlast_phase, so the failing owner and reason show up instead of an unresponsive-app hint.Closes #374
Co-authored-by: Prince Jain 117412569+princejain756@users.noreply.github.com