Skip to content

Conversation

@devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Feb 8, 2026

Extends the error components API to give better control over recovery. Previously, the reset() prop only cleared the error state and re-rendered the children. However, this only handles a temporary rendering error.

The error can be due to data fetching or an RSC phase. In these cases, reset() alone is not sufficient. Users would even need to implement retry logic using router.refresh().

Therefore, this PR adds a new retry() prop that calls router.refresh() and reset() within a startTransition() to provide built-in retry logic. This feature is expected to be preferred over the reset() prop. Only the cases where you'd choose reset() are when you have a reason to do a sync reset without loading any new data.

This PR also adds componentStack and ownerStack (dev-only) to the error components API to improve DX and debugging of error handling.

Closes NAR-767

Copy link
Member Author

devjiwonchoi commented Feb 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 8, 2026

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 8, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 467 MB 467 MB 🔴 +99.6 kB (+0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 458ms ▁▁▁▁▁
Cold (Ready in log) 456ms 460ms ▂▁▂▂▂
Cold (First Request) 850ms 854ms ▅▁▅▅▅
Warm (Listen) 456ms 455ms ▁▁▁▁▁
Warm (Ready in log) 455ms 455ms ▁▁▁▁▁
Warm (First Request) 361ms 364ms ▁▁▁▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁▁▁
Cold (Ready in log) 438ms 437ms ▄▁▆▁▃
Cold (First Request) 1.843s 1.838s ▂▂▂▁▁
Warm (Listen) 456ms 455ms ▁▁▁▁▁
Warm (Ready in log) 437ms 437ms ▄▂▃▁▄
Warm (First Request) 1.847s 1.847s ▂▃▂▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.193s 4.152s ▁▁▁▁▁
Cached Build 4.191s 4.169s ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.910s 13.951s ▁▃▁▁▁
Cached Build 14.001s 13.965s ▁▃▁▂▁
node_modules Size 467 MB 467 MB 🔴 +99.6 kB (+0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **437 kB** → **438 kB** ⚠️ +162 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 756 B 763 B
Total 756 B 763 B ⚠️ +7 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 452 B
Total 451 B 452 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 57 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 254 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.8 kB -
Total 230 kB 231 kB ⚠️ +766 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 249 kB 250 kB
Total 375 kB 376 kB ⚠️ +580 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 614 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 33 kB 33.2 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.6 kB 34.8 kB ⚠️ +179 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 733 B 735 B
Total 733 B 735 B ⚠️ +2 B
Build Cache
Canary PR Change
0.pack gzip 3.83 MB 3.85 MB 🔴 +17.3 kB (+0%)
index.pack gzip 103 kB 104 kB
index.pack.old gzip 103 kB 102 kB
Total 4.04 MB 4.06 MB ⚠️ +17.5 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 315 kB 316 kB
app-page-exp..prod.js gzip 167 kB 168 kB
app-page-tur...dev.js gzip 315 kB 316 kB
app-page-tur..prod.js gzip 167 kB 168 kB
app-page-tur...dev.js gzip 312 kB 312 kB
app-page-tur..prod.js gzip 166 kB 166 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 166 kB 166 kB
app-route-ex...dev.js gzip 70.5 kB 70.5 kB
app-route-ex..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70.1 kB 70.1 kB
app-route-tu..prod.js gzip 48.8 kB 48.8 kB
app-route.ru...dev.js gzip 70.1 kB 70.1 kB
app-route.ru..prod.js gzip 48.7 kB 48.7 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB
pages-turbo....dev.js gzip 52.5 kB 52.5 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 52.5 kB 52.5 kB
pages.runtim..prod.js gzip 39.3 kB 39.3 kB
server.runti..prod.js gzip 62.7 kB 62.7 kB
Total 2.8 MB 2.8 MB ⚠️ +1.87 kB
📝 Changed Files (8 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js

Diff too large to display

@devjiwonchoi devjiwonchoi force-pushed the jiwon/02-08-add_retry_logic_for_error.js branch 2 times, most recently from 4bc9128 to 3cd7ff9 Compare February 9, 2026 01:17
@devjiwonchoi devjiwonchoi changed the title Add retry, componentStack, and ownerStack to error.js Add retry(), componentStack, and ownerStack to error.js Feb 9, 2026
Extends the error components API to give better control over recovery.
Previously, the `reset` prop only cleared the error state and re-rendered
the children. However, this only handles a temporary error during rendering.

The error can be from data fetching, or from a RSC phase etc. So in these
cases `reset` alone is not enough. The users would even need to implement
a retry logic with `router.refresh()`.

Therefore this commit adds a new `retry` prop which calls `router.refresh()`
and `reset` inside a `startTransition` to provide a built-in retry logic.
This feature is expected to preferred over than the `reset` prop. Only the
cases where you'd choose `reset` is when you have a reason to do sync reset
without loading any new data.

This commit also adds `componentStack` and `ownerStack` (dev-only) to the
error components API for better DX and debugging error handling.
@devjiwonchoi devjiwonchoi force-pushed the jiwon/02-08-add_retry_logic_for_error.js branch from 3cd7ff9 to e5e0973 Compare February 9, 2026 22:06
@devjiwonchoi devjiwonchoi force-pushed the jiwon/02-08-allow_reset_from_user_s_global-error branch from 564cf7e to 2a614e7 Compare February 9, 2026 22:06
error-boundary.tsx imported publicAppRouterInstance from app-router-instance.ts, which transitively pulls in the entire App Router module graph (router-reducer → fetch-server-response →
  react-server-dom-webpack/client). This broke any non-App-Router context (e.g. Pages Router) that imports a module depending on error-boundary.tsx, since react-server-dom-webpack/client is
  unavailable there. Replace with AppRouterContext from the lightweight shared-runtime module, which only contains type imports and React context creation — no heavy runtime dependencies. The error
  boundary already renders inside the AppRouterContext.Provider scope, so this.context always has the router instance for segment-level boundaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants