Skip to content

Conversation

@lukesandberg
Copy link
Contributor

@lukesandberg lukesandberg commented Feb 9, 2026

Fix a few cases we track modification after making the mutation instead of before it.

For snapshotting to work correctly we need to snapshot the task before it is modified to provide a consistent view of the database (well a point in time consistent view).

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Feb 9, 2026
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lukesandberg lukesandberg changed the title fix modification tracking [turbopack] Fix some modification tracking bugs in TaskStorage Feb 9, 2026
@lukesandberg lukesandberg marked this pull request as ready for review February 9, 2026 09:43
@lukesandberg lukesandberg requested a review from a team February 9, 2026 09:43
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 9, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing fix_modification_tracking (6998a14) with canary (a0b5d9a)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants