This repository was archived by the owner on Jan 3, 2024. It is now read-only.
build: strip signature from compiled macOS base binary#179
Merged
Conversation
Newer versions of Apple Clang automatically ad-hoc sign the compiled executable, due to the new mandatory code signing requirement [1]. However, for final executable to be signable, base binary MUST NOT have an existing signature. This change strips the ad-hoc signature from compiled macOS base binary. [1]: https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11_0_1-universal-apps-release-notes Refs: vercel/pkg#1164 Bug: vercel/pkg#1023
Contributor
Author
|
With this PR and vercel/pkg#1164, it is now possible to build a working executable for macos-arm64 platform (Apple M1). Unfortunately, while it is possible to compile x86 Node binaries on arm64 Macs, it is not possible at the moment to compile arm64 Node binaries on x86 Macs due to issues of Node build system. As Github Actions only provide x86 Macs, we can't provide binaries for macos-arm64 platform at the moment. |
Contributor
Author
|
However, I can build binaries on my personal arm64 Mac, and upload them to the repo. Shall I? @leerob @robertsLando |
robertsLando
approved these changes
May 10, 2021
Contributor
robertsLando
left a comment
robertsLando
left a comment
There was a problem hiding this comment.
LGTM. Also I think that the temporary solution you proposed is fine
Contributor
Author
|
Great. I will build Node 14 and 16 macos-arm64 binaries then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions of Apple Clang automatically ad-hoc sign the compiled
executable, due to the new mandatory code signing requirement 1.
However, for final executable to be signable, base binary MUST NOT
have an existing signature.
This change strips the ad-hoc signature from compiled macOS base binary.
Refs: vercel/pkg#1164
Bug: vercel/pkg#1023