fix position twitter icon for dir=rtl#102
Merged
lfades merged 1 commit intovercel:mainfrom Aug 3, 2023
Merged
Conversation
lfades
approved these changes
Aug 3, 2023
Member
lfades
left a comment
lfades
left a comment
There was a problem hiding this comment.
It looks better with this change. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers,
The margin-left property was changed to margin-inline-start to have proper position of the Twitter icon on websites with dir attribute set to rtl direction. This change resolves the visual inconsistencies. The modification has been tested and does not impact left-to-right websites.