Merged
Conversation
use 0.5rem spacing
Member
|
It's better spacing but the current spacing matches the one in https://publish.twitter.com/?query=https%3A%2F%2Ftwitter.com%2Fvercel%2Fstatus%2F1683920951807971329&widget=Tweet. |
Contributor
Author
|
@lfades: That's apparently a styling bug Twitter left in that blockquote render. You can see that the spacing is only 4px compared to 12px in the normal UI:
We can all see it's off, hell we could even make Twitter (or X, whatever) aware of it. The padding on the bottom of that row is 12px, in the Twitter UI it is 12px - the spacing should be twelve pixels. |
lfades
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
0.5remof spacing instead of0.25rem. See comparison below.0.5rem(proposed)0.25rem(previous)