Open
Conversation
Author
|
Looks like the CI build failed due to the Zeit/Vercel rename... |
|
Thanks for figuring this out @ottobonn! Running into this issue with people trying to use styled-jsx with media-chrome custom elements. Is there something I can do to help get this over the line? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is my follow-up to the discussion in vercel/next.js#13376. It adds support for custom HTML tags (whose names are lower case and contain hyphens) to styled-jsx.
Here's an example of such a tag in React:
Before this PR, the output of styled-jsx would be:
This output is not quite right, because React passes through the raw
classattribute of the element for custom HTML tags, and styled-jsx is attaching additional class names toclassName.This PR adds code to detect custom element names and to use
classinstead ofclassNamefor them.