Don't persist workspace directory

[pantherman594]

The workspace directory needs to be empty to remount resources. Mount a tmpfs volume over the workspace directory so it will always be empty even if the home directory is persisted with a volume.

PHP-114909

[yuhuyoyo]

why does the workspace directory needs to be empty?

[pantherman594]

wb resource mount first unmounts all resources:

https://github.com/verily-src/verily1/blob/0a584f90b4a9f055ddb69c3efffda4c1fec4b8e9/workbench/cli/src/main/java/bio/terra/cli/command/resource/Mount.java#L85

which requires the workspace directory to be empty:

https://github.com/verily-src/verily1/blob/0a584f90b4a9f055ddb69c3efffda4c1fec4b8e9/workbench/cli/src/main/java/bio/terra/cli/utils/mount/MountController.java#L186

If this fails, resources will fail to be mounted

[june-hua]

You mentioned in the jira item's comments that

other apps do not mount a persistent volume to the user’s home directory

Why is this not the case for r-studio?

[pantherman594]

You mentioned in the jira item's comments that

other apps do not mount a persistent volume to the user’s home directory

Why is this not the case for r-studio?

I think the intention was to persist user files and configurations across app restarts (#93) but out of the apps changed r-studio is the only one we still have. vscode mounts a volume to /home/vscode but the home directory is actually /config so mounting isn't affected

I could change the persisted directory to /home/rstudio/work like we do with our example apps but if anyone is relying on the current behavior of files persisting in the home directory I don't want to unexpectedly change that

[june-hua]

You mentioned in the jira item's comments that

other apps do not mount a persistent volume to the user’s home directory

Why is this not the case for r-studio?

I think the intention was to persist user files and configurations across app restarts (#93) but out of the apps changed r-studio is the only one we still have. vscode mounts a volume to /home/vscode but the home directory is actually /config so mounting isn't affected

I could change the persisted directory to /home/rstudio/work like we do with our example apps but if anyone is relying on the current behavior of files persisting in the home directory I don't want to unexpectedly change that

If I'm reading this correctly, seems like for other apps, including jupyter-template, the home directory is '/home/jupyter'.
Is it that it doesn't mount a persistent volume to the home directory?

[pantherman594]

If I'm reading this correctly, seems like for other apps, including jupyter-template, the home directory is '/home/jupyter'.
Is it that it doesn't mount a persistent volume to the home directory?

Yeah rstudio is the only app that mounts a persistent volume to the home directory

[june-hua]

Looks like the setup (i.e. whether home directory mounts persistent volume, the working directory path) differs between r-studio, vscode, and jupyterlab.

Would it be possible to make this consistent across all apps? Not sure what the rationale was behind this difference?
cc @yuhuyoyo