fix: make vike-cloudflare a real Vike extension (#37)

[brillout]

No description provided.

[cloudflare-workers-and-pages]

Deploying vike-cloudflare-vike-demo with    Cloudflare Pages

Latest commit:	8eb25a7
Status:	✅  Deploy successful!
Preview URL:	https://d580c375.vike-clouflare-vike-demo.pages.dev
Branch Preview URL:	https://brillout-dev.vike-clouflare-vike-demo.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying vike-cloudflare-hono-demo with    Cloudflare Pages

Latest commit:	8eb25a7
Status:	✅  Deploy successful!
Preview URL:	https://773f4eed.vike-clouflare-hono-demo.pages.dev
Branch Preview URL:	https://brillout-dev.vike-clouflare-hono-demo.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying vike-cloudflare-hattip-demo with    Cloudflare Pages

Latest commit:	8eb25a7
Status:	✅  Deploy successful!
Preview URL:	https://75feb328.vike-clouflare-hattip-demo.pages.dev
Branch Preview URL:	https://brillout-dev.vike-clouflare-hattip-demo.pages.dev

View logs

[brillout]

The test examples/vike-app/.test-preview.test.ts seems to fail only because wrangler logs something on stderr:

FAIL  /home/runner/work/vike-cloudflare/vike-cloudflare/examples/vike-app/.test-preview.test.ts
Test  FAIL  because error(s)/warning(s) occurred during server termination, see below. [TEST_FAIL]
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
vvvvvv ERROR & WARNING LOGS vvvvvv
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[20:19:17.[137](https://github.com/vikejs/vike-cloudflare/actions/runs/12937347304/job/36085068099?pr=39#step:8:138)][/examples/vike-app][pnpm run preview --port 3000][stderr] 🪵  Logs were written to "/home/runner/.config/.wrangler/logs/wrangler-2025-01-23_20-19-14_233.log"

I wonder why it does this only in this PR, not in main. I can't think of a change introduced by this PR that would explain this log.

[brillout]

I found why: it's because Vike logs a new warning on stderr. It seems that if something is logged on stderr then wrangler logs Logs were written to ... on stderr.

[brillout]

The warning is this:

[vike][Warning] The environment is set to be a development environment by process.env.NODE_ENV===null, which seems contradictory because the environment seems to be a production environment (Vite isn't loaded), see https://vike.dev/NODE_ENV

Removing that warning makes the CI green for examples/vike-app/.

How can we get rid of that warning? Ideas on why process.env.NODE_ENV isn't 'production'?

See also:

• 🐛 BUG: process.env.NODE_ENV is not set to production by default cloudflare/workers-sdk#7886
• 0a63a4a

It's surprising that it's 'production' at packages/vike-cloudflare/assets/vike.js but null inside Vike's code. Maybe it's a Vite misconfiguration on vike-cloudflare's side?

[brillout]

It's surprising that it's 'production' at packages/vike-cloudflare/assets/vike.js but null inside Vike's code. Maybe it's a Vite misconfiguration on vike-cloudflare's side?

The warning code isn't inside dist/ so this doesn't seem to be the issue. It does seem to be a Wrangler issue after all.

[brillout]

The examples/vike-app/ is now green. I'll have a look at why the other ones are red later.

[brillout]

It's only examples/hattip-app/.test-preview.test.ts that is red, the rest is green. I suspect it's something to do with @hattip/vite.

[magne4000]

It's only examples/hattip-app/.test-preview.test.ts that is red, the rest is green. I suspect it's something to do with @hattip/vite.

I found a fix/workaround. Not perfect, but at least it seems to work

[magne4000]

@brillout still a draft or this can be merged?

[brillout]

I think it's best I finish my refactoring endeavour first. I'll keep you updated — ETA this week.

[brillout]

From my perspective this can be merged now.

[magne4000]

Really cool!