fix(widgets): Respect min/maxZoom#10033
Merged
felixpalmer merged 4 commits intomasterfrom Mar 3, 2026
Merged
Conversation
chrisgervang
approved these changes
Feb 27, 2026
| // TODO - MOVE TO WIDGETIMPL? | ||
| setViewState(viewState: ViewState) { | ||
| flyTo(viewState: ViewState) { | ||
| const viewId = this.props.viewId || (viewState?.id as string) || 'default-view'; |
Collaborator
There was a problem hiding this comment.
#10042 has a new pattern for when viewId isn't specified, and I think it'd make sense to do across the board. I see a few places we could add it in this PR
Collaborator
Author
There was a problem hiding this comment.
@chrisgervang I've done a pass to make it consistent, can you confirm you're happy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9679
Background
Widgets have no clean way to access the
viewStateand currently use theviewportin a number of places. This leads to themin/maxZoomprops being dropped. As a result theZoomWidgetdoesn't respect the limits, but also clicking theCompassWidgetremoves themin/maxZoomfrom the view state and after that even the normal interaction via theControlleris broken.Change List
getViewState&setViewStatehelpers toWidgetviewStaterather thanviewportwhen calculatenextViewStateZoomWidget