Skip to content

fix(widgets): popover components improvements#10041

Merged
Pessimistress merged 2 commits intomasterfrom
x/widget-popover-3
Feb 25, 2026
Merged

fix(widgets): popover components improvements#10041
Pessimistress merged 2 commits intomasterfrom
x/widget-popover-3

Conversation

@Pessimistress
Copy link
Copy Markdown
Collaborator

Change List

  • Render popover element inside deck DOM tree (to inherit theming CSS variables and proper removal upon unmount)
  • Update popover position on page scrolls, resizes or layout updates

Copy link
Copy Markdown
Collaborator

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still work for your use case if they're mounted in the deck stack?

)}
{children}
</div>,
document.body
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, body wouldn't have these variables defined unless a stylesheet put them on :root. Everything can be inherited if they stay in the deck stack.

@Pessimistress Pessimistress merged commit 8700b95 into master Feb 25, 2026
3 checks passed
@Pessimistress Pessimistress deleted the x/widget-popover-3 branch February 25, 2026 22:07
@ibgreen
Copy link
Copy Markdown
Collaborator

ibgreen commented Mar 1, 2026

A related question that I have been thinking about:

  • Would it be possible to specify a "portal" for the popover, so that the popup can take advantage of overlapping any available space in the app outside of the deck canvas. Right now we do this with React.createPortal in apps but one thing that pushes us away from using pure deck widgets for this.
  • A portal mode could be useful for any widget that pops up something.

@FatahChan
Copy link
Copy Markdown

when will this be in release?

@chrisgervang chrisgervang added this to the v9.3 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants