fix: updates pydeck pyproject.toml to include dynamic field#10048
Merged
Pessimistress merged 1 commit intovisgl:masterfrom Mar 10, 2026
Merged
fix: updates pydeck pyproject.toml to include dynamic field#10048Pessimistress merged 1 commit intovisgl:masterfrom
Pessimistress merged 1 commit intovisgl:masterfrom
Conversation
chrisgervang
approved these changes
Mar 4, 2026
updates pydeck pyproject.toml to include dynamic field Signed-off-by: Lance Barto <lbarto@redhat.com>
79816b7 to
fbc548a
Compare
Contributor
Author
|
I've rebased and updated the PR with the changes suggested by the bot. This should be g2g. sorry for the delay |
chrisgervang
pushed a commit
that referenced
this pull request
Apr 17, 2026
updates pydeck pyproject.toml to include dynamic field Signed-off-by: Lance Barto <lbarto@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10047
Background
pydeck's pyproject.toml has a minimal [project] table (only name, version, requires-python) while all package metadata — description, readme, license, authors, keywords, classifiers, dependencies, optional-dependencies — is defined in setup.py. Modern setuptools requires that any field defined outside of pyproject.toml be explicitly declared in dynamic; without it, setuptools silently ignores those values.
The fatal error is specifically caused by readme not being listed as dynamic:
AttributeError: 'NoneType' object has no attribute 'get'
Because readme is not declared dynamic, setuptools passes None to its internal _long_description handler instead of the actual value from setup.py, which then crashes when it tries to call .get() on it.
After the updates, the wheel builds successfully:
Change List
Note
Low Risk
Low risk: packaging-only change that affects how metadata is sourced during builds, with no runtime behavior impact.
Overview
Ensures
pydeckbuilds correctly with modern setuptools by adding adynamiclist tobindings/pydeck/pyproject.toml, allowing metadata (e.g.,readme,license,authors, and dependency fields) to be populated fromsetup.pyinstead of being ignored.Written by Cursor Bugbot for commit 79816b7. This will update automatically on new commits. Configure here.