feat(chore): new Deck metrics#10100
Merged
Pessimistress merged 2 commits intomasterfrom Mar 18, 2026
Merged
Conversation
Pessimistress
commented
Mar 15, 2026
| )(); | ||
|
|
||
| if (stats) { | ||
| stats.get('Redraw Layers').add(visibleCount); |
Collaborator
Author
There was a problem hiding this comment.
This was unreachable code
Pessimistress
commented
Mar 15, 2026
ibgreen
approved these changes
Mar 17, 2026
| metrics.cpuTimePerFrame = stats.get('CPU Time').getAverageTime(); | ||
|
|
||
| const memoryStats = luma.stats.get('Memory Usage'); | ||
| const memoryStats = luma.stats.get('GPU Time and Memory'); |
Collaborator
There was a problem hiding this comment.
Yes...
Copying from the stats object using user facing strings is obviously fragile. If this is just for a one or two values it might be better for luma to provide a metrics api for those, or add more stable ids to the Stats,...
My idea was that the StatsWidget would show the various stats objects from deck and luma so that the user would have all the info available, not sure if that was implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change List