fix(mapbox): onBefore|AfterRender fires without layers#10166
Merged
felixpalmer merged 4 commits intomasterfrom Apr 2, 2026
Merged
fix(mapbox): onBefore|AfterRender fires without layers#10166felixpalmer merged 4 commits intomasterfrom
felixpalmer merged 4 commits intomasterfrom
Conversation
chrisgervang
approved these changes
Apr 2, 2026
Collaborator
chrisgervang
left a comment
chrisgervang
left a comment
There was a problem hiding this comment.
Can we add a unit test for this?
chrisgervang
added a commit
that referenced
this pull request
Apr 2, 2026
Port onBeforeRender/onAfterRender test from #10166 to overlay spec (master added it to the deleted mapbox-layer.spec.ts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When using
interleaved=trueMapboxOverlaytheonBeforeRenderandonAfterRenderhooks not fire when we have no layersChange List
onBeforeRender&onAfterRender