Conversation
|
coverage: 83.746% (-0.002%) from 83.748% — ib/view-parameters into master |
| blendAlphaOperation: 'add' | ||
| } | ||
| : {}; | ||
| if (getProjection(map) === 'globe') { |
There was a problem hiding this comment.
@chrisgervang @felixpalmer @charlieforward9 this would presumably no longer be needed
|
|
||
| #### `parameters` (object, optional) {#parameters} | ||
|
|
||
| `GlobeView` enables back-face culling by default with `parameters: {cullMode: 'back'}`. To override this behavior, supply the desired GPU parameters to the constructor: |
There was a problem hiding this comment.
I'm not sure we should be doing this, it is a workaround. At least in the long-term we should aspire to remove this as the correct fix is to correct the shader math: #9592 (comment)
There was a problem hiding this comment.
it is a workaround. At least in the long-term we should aspire to remove this as the correct fix is to correct the shader math
I would agree that another solution for GlobeView specifically would be preferable, however the feature in this PR is quite orthogonal: Deck parameters < View parameters < Layer parameters, so no harm in landing it now.
5 participants
Summary
Adds a
parametersprop to deck.glViewclasses so GPU draw parameters can be configured per view.parameters?: ParameterstoCommonViewPropsDeck.parameters<View.parameters< layer/pass parametersGlobeViewdefaultparameters: {cullMode: 'back'}while allowing per-instance overridesTesting
git diff --checkyarn test test/modules/core/views/view.spec.ts test/modules/core/passes/layers-pass.spec.tsyarn lintyarn build