docs: Use Popup in Maplibre/Mapbox getting started example#8956
Merged
felixpalmer merged 6 commits intomasterfrom Jun 20, 2024
Merged
docs: Use Popup in Maplibre/Mapbox getting started example#8956felixpalmer merged 6 commits intomasterfrom
felixpalmer merged 6 commits intomasterfrom
Conversation
Pessimistress
approved these changes
Jun 19, 2024
Collaborator
Pessimistress
left a comment
There was a problem hiding this comment.
Should the mapbox example be updated as well?
chrisgervang
approved these changes
Jun 19, 2024
Collaborator
chrisgervang
left a comment
There was a problem hiding this comment.
Definitely a more useful example this way. Though, I'm not sure I understand your comment about reverse-control since this isn't that. Those examples are all in website whereas this is considered to be using the overlay pattern.
Collaborator
Author
|
@chrisgervang what I was getting at regarding "reverse-controlled" is that newcomers will look at our examples (get-started or website) and pick whatever looks most appropriate, not realizing that they've chosen an integration mode. Then when it comes to adding a Popup, they might get stuck if they "accidentally" picked a reverse-controlled pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8530
Background
This is a common use case and it isn't trivial as it isn't obvious that it isn't possible to do this with the "reverse-controlled" React pattern.
Change List
Popupcomponent instead ofalert()