Skip to content

chore: clean some leftovers from Vite core#44

Merged
patak-cat merged 1 commit intomainfrom
clean-deps
Dec 5, 2022
Merged

chore: clean some leftovers from Vite core#44
patak-cat merged 1 commit intomainfrom
clean-deps

Conversation

@ArnaudBarre
Copy link
Copy Markdown
Member

The clean up of unused test utils is totally arbitrary. I kept some that would probably be useful in the future like addFile but removed some that felt more specific like formatSourcemapForSnapshot

@ArnaudBarre
Copy link
Copy Markdown
Member Author

I started a release by mistakes, sure that i wouldn't have npm permissions anyway, but forgot that it would push a git tag to GH.

I deleted the alpha-3 tag, pushed an alpha-2 tag so that the changelog is correct the next time.

We need to decide if we do CI publish or not. I see that you updated the TS script but the package.json entry was removed (the CI failure)

@patak-cat
Copy link
Copy Markdown
Member

@ArnaudBarre if I understand correctly, you are simplifying the publish script here because there is only one package? I thought we could leave it as is, as we may end up extracting this into a repo utils package later. And we could detect if there is only one option and avoid the prompt only (but the rest remains intact)

@ArnaudBarre
Copy link
Copy Markdown
Member Author

I kept the release script multi-packages enable, just remove vite et create-vite edge cases that would be always false in the future. I'm pretty sure any published packages in the monorepo will be under @vitejs namespace

Copy link
Copy Markdown
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, I got confused by some parts of the changelog. Makes sense.

@patak-cat patak-cat merged commit d2a3931 into main Dec 5, 2022
@patak-cat patak-cat deleted the clean-deps branch December 5, 2022 09:28
sapphi-red pushed a commit that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants