Skip to content

ci: fix playwright cache#11254

Merged
patak-cat merged 6 commits intovitejs:mainfrom
sapphi-red:fix/playwright-cache
Dec 8, 2022
Merged

ci: fix playwright cache#11254
patak-cat merged 6 commits intovitejs:mainfrom
sapphi-red:fix/playwright-cache

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

playwright cache wasn't working and this PR fixes that.
https://github.com/vitejs/vite/actions/runs/3645678953/jobs/6156032178#step:9:11

I thought actions/cache saves the directory if it's changed. But I noticed that it only saves when the cache didn't hit.
https://github.com/vitejs/vite/actions/runs/3645678953/jobs/6156032178#step:25:2

refs #8599

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Dec 8, 2022
@patak-cat patak-cat merged commit b7174ed into vitejs:main Dec 8, 2022
@sapphi-red sapphi-red deleted the fix/playwright-cache branch December 8, 2022 07:26
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
sapphi-red added a commit to vitejs/vite-plugin-react that referenced this pull request Apr 1, 2025
sapphi-red added a commit to vitejs/vite-plugin-react that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants