You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When processing CSS from proxy the filePath is an empty string or a relative path without a filename so we fail the first condition and try to read the file from the file system.
What is the purpose of this pull request?
Bug fix
New Feature
Documentation update
Other
Before submitting the PR, please make sure you do the following
The reason will be displayed to describe this comment to others. Learn more.
When running the playground, I got "" (empty string) as a value of filePath. I think this doesn't make sense and it's a bug in Lightning CSS. But I think it's fine to merge this as a workaround for now.
We can merge this PR as a temporal patch as suggested, but I think more tests are needed and the way id is converted to filename here doesn't seems correct to me. What happens when the id is a virtual module? Several html-proxy ids could end up mapped to the same filename, no? And then this filename is resolved and added to deps. Shouldn't there be a way to respect the id that has already been resolved and for which we already have the src and avoid re-resolving it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug when using Lightning CSS with Vite Server and html-proxy
Additional context
The issue was originally found when attempting to use Storybook with + Vitejs 4.4 with the
lightningcssoptioins enabled.The shell app builds but when build the preview iframe it breaks with the error:
node:internal/process/promises:288 triggerUncaughtException(err, true /* fromPromise */); ^ [Error: GenericFailure] { code: 'GenericFailure', plugin: 'vite:css', id: '\x00/iframe.html?html-proxy&direct&index=0.css', pluginCode:[css code] }I would guess the problem is here: https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/css.ts#L2176:L2181
When processing CSS from proxy the
filePathis an empty string or a relative path without a filename so we fail the first condition and try to read the file from the file system.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).