Skip to content

feat: warn if ? in project root#15755

Closed
steadily-worked wants to merge 2 commits intovitejs:mainfrom
steadily-worked:main
Closed

feat: warn if ? in project root#15755
steadily-worked wants to merge 2 commits intovitejs:mainfrom
steadily-worked:main

Conversation

@steadily-worked
Copy link
Copy Markdown

Description

Fix #15726

Additional context


since both # and ? are targets for remaining, i use forEach.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@steadily-worked steadily-worked changed the title feat: also warn if ? in project root feat: also warn if ? in project root Jan 31, 2024
@steadily-worked steadily-worked changed the title feat: also warn if ? in project root feat: warn if ? in project root Jan 31, 2024
@steadily-worked
Copy link
Copy Markdown
Author

It seems that I overlooked the fact that the warning appears unnecessarily twice when both # and ? are included. There is already a separate PR(even testing included) addressing this case(#15761), so I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Also warn when absolute file paths include ? during build (relates to #14165)

1 participant