fix: fix sourcemap when using object as define value #15805
Merged
patak-cat merged 17 commits intovitejs:mainfrom Apr 3, 2024
Merged
fix: fix sourcemap when using object as define value #15805patak-cat merged 17 commits intovitejs:mainfrom
define value #15805patak-cat merged 17 commits intovitejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wrote my findings in #15771 (comment). The issue seems to be esbuild including multiple
sourcesin source map when it cannot replace "define" value with primitive (esbuild example) while later pipeline for source map collapsing/remapping doesn't expect such extrasourcesentries.Since it doesn't look possible to control how esbuild output source entries, I think one way to "fix" this issue is to simply remove all extra source map entries which doesn't correspond to the original source. In this PR, I attempted this approach by using utilities from
@jridgewell/trace-mapping(which is mostly re-exports of@jridgewell/sourcemap-codec).todo
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).