Skip to content

fix(css): don't transform sass function calls with namespace#18414

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/support-sass-function-call-with-namespace
Oct 21, 2024
Merged

fix(css): don't transform sass function calls with namespace#18414
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/support-sass-function-call-with-namespace

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

This PR fixes background: url(string.to-lower-case($var2)); to be not to transformed. I found this while fixing the deprecation warnings coming from sass.

@sapphi-red sapphi-red added feat: css p2-edge-case Bug, but has workaround or limited in scope (priority) labels Oct 21, 2024
},
],
silenceDeprecations: ['legacy-js-api'],
silenceDeprecations: ['legacy-js-api', 'import'],
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added import to silenceDeprecations due to sass/embedded-host-node#340.

@patak-cat patak-cat enabled auto-merge (squash) October 21, 2024 10:39
@patak-cat patak-cat merged commit dbb2604 into vitejs:main Oct 21, 2024
@sapphi-red sapphi-red deleted the fix/support-sass-function-call-with-namespace branch October 22, 2024 01:43
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: css p2-edge-case Bug, but has workaround or limited in scope (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants