refactor: enable no-unnecessary-condition#18798
Closed
sapphi-red wants to merge 9 commits intovitejs:mainfrom
Closed
refactor: enable no-unnecessary-condition#18798sapphi-red wants to merge 9 commits intovitejs:mainfrom
sapphi-red wants to merge 9 commits intovitejs:mainfrom
Conversation
91a3c3f to
07c94c8
Compare
e8a6abf to
fa50e82
Compare
Member
Author
|
Added exhaustiveness check suggested in typescript-eslint/typescript-eslint#10283 (comment) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
built on top of #18797
By combining with #18796, we can catch errors like
Also I found many cases like above, even if we don't enable this rule, I think we should merge the change parts.