fix(css): temporary add ?. after this.getModuleInfo in vite:css-post#19478
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Feb 21, 2025
Merged
Conversation
Member
Author
|
/ecosystem-ci run |
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
|
📝 Ran ecosystem CI on
✅ analogjs, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, react-router, storybook, sveltekit, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-plugin-cloudflare, vite-setup-catalogue, vitepress, vuepress, waku |
dominikg
approved these changes
Feb 21, 2025
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
unocss passes
{}as the pluginContext andthis.getModuleInfoisundefinedin that case.https://github.com/unocss/unocss/blob/355558bd779997f61aab798b2a1912426064b216/packages-integrations/vite/src/modes/global/build.ts#L183-L187
#19418 added a
this.getModuleInfocall and broke unocss.This is technically a bug in unocss, but since the patch on our side is small and can avoid breakage on their side, I think we can add this
?.for now. Let's remove it in Vite 7.See https://discord.com/channels/804011606160703521/1342361424370077818/1342395667598938202