Skip to content

refactor: remove no-op legacy.proxySsrExternalModules #20013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
May 16, 2025
+0 −12
Merged

refactor: remove no-op legacy.proxySsrExternalModules #20013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/vite/src/node/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,17 +512,6 @@ export interface ExperimentalOptions {
}

export interface LegacyOptions {
/**
* In Vite 4, SSR-externalized modules (modules not bundled and loaded by Node.js at runtime)
* are implicitly proxied in dev to automatically handle `default` and `__esModule` access.
* However, this does not correctly reflect how it works in the Node.js runtime, causing
* inconsistencies between dev and prod.
*
* In Vite 5, the proxy is removed so dev and prod are consistent, but if you still require
* the old behaviour, you can enable this option. If so, please leave your feedback at
* https://github.com/vitejs/vite/discussions/14697.
*/
proxySsrExternalModules?: boolean
/**
* In Vite 6.0.8 and below, WebSocket server was able to connect from any web pages. However,
* that could be exploited by a malicious web page.
Expand Down Expand Up @@ -706,7 +695,6 @@ export const configDefaults = Object.freeze({
removeSsrLoadModule: undefined,
},
legacy: {
proxySsrExternalModules: false,
skipWebSocketTokenCheck: false,
},
logLevel: 'info',
Expand Down