Skip to content

feat(ssr): add import.meta.main support for Node.js module runner #20517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 8 commits into from
Aug 5, 2025
Merged

feat(ssr): add import.meta.main support for Node.js module runner #20517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a820fc
Initial plan
Copilot Jul 31, 2025
b527967
Add import.meta.main support for module runner
Copilot Jul 31, 2025
5a952e7
Address review feedback: import.meta.main always false in Node.js, ad…
Copilot Aug 1, 2025
120a8bd
chore: update
sapphi-red Aug 1, 2025
b799d76
Group import.meta tests with describe block and dedupe navigation
Copilot Aug 1, 2025
c4a9c1e
Address review feedback: Update describe block structure and test name
Copilot Aug 1, 2025
7556bad
revert: remove describe block structure from import.meta tests
Copilot Aug 1, 2025
f2a2885
update
sapphi-red Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/vite/src/module-runner/createImportMeta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export async function createNodeImportMeta(

return {
...defaultMeta,
main: false,
resolve(id: string, parent?: string) {
const resolver = importMetaResolver ?? defaultMeta.resolve
return resolver(id, parent ?? href)
Expand Down
6 changes: 6 additions & 0 deletions playground/ssr/__tests__/ssr.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ test(`import.meta.resolve is supported`, async () => {
expect(await page.textContent('.import-meta-resolve')).toBe(metaUrl)
})

test(`import.meta.main is supported`, async () => {
await page.goto(`${url}/import-meta`)

expect(await page.textContent('.import-meta-main')).toBe('false')
})

test.runIf(isServe)('html proxy is encoded', async () => {
await page.goto(
`${url}?%22%3E%3C/script%3E%3Cscript%3Econsole.log(%27html%20proxy%20is%20not%20encoded%27)%3C/script%3E`,
Expand Down
4 changes: 3 additions & 1 deletion playground/ssr/src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ async function renderForkedDeadlockDynamicImports(rootDir) {
async function renderImportMeta(rootDir) {
const metaUrl = import.meta.url
const resolveResult = import.meta.resolve('./app.js')
const metaMain = import.meta.main
return (
`<div class="import-meta-url">${escapeHtml(metaUrl)}</div>` +
`<div class="import-meta-resolve">${escapeHtml(resolveResult)}</div>`
`<div class="import-meta-resolve">${escapeHtml(resolveResult)}</div>` +
`<div class="import-meta-main">${escapeHtml(String(metaMain))}</div>`
)
}
Loading