feat: rename server.hmr options to server.ws options#21357
Open
sapphi-red wants to merge 3 commits intomainfrom
Open
feat: rename server.hmr options to server.ws options#21357sapphi-red wants to merge 3 commits intomainfrom
server.hmr options to server.ws options#21357sapphi-red wants to merge 3 commits intomainfrom
Conversation
sapphi-red
added
the
p2-edge-case
bluwy
reviewed
Jan 6, 2026
Comment on lines
+1389
to
+1391
| if (rootPath === 'server') { | ||
| setupHmrWsOptionCompat(merged) | ||
| } |
Member
There was a problem hiding this comment.
It's a bit strange for me to put compat code in the merge function, but I suppose it works temporarily for now.
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that it's not possible to configure the ws settings when the HMR is disabled by
server.hmr: false. This PR moves all ws related options underserver.hmrtoserver.ws. This would make it possible to configure ws settings while disabling HMR.fixes #18489
refs #18489 (comment), #18489 (comment)