Skip to content

fix: don't replace process.env if process not global variable#3703

Merged
antfu merged 4 commits intovitejs:mainfrom
cawa-93:patch-1
Jun 8, 2021
Merged

fix: don't replace process.env if process not global variable#3703
antfu merged 4 commits intovitejs:mainfrom
cawa-93:patch-1

Conversation

@cawa-93
Copy link
Copy Markdown
Contributor

@cawa-93 cawa-93 commented Jun 7, 2021

Description

Try to fix #3701

Additional context

  • The string from replacements will not be replaced if the . (dot) goes before it.
  • Also added a few additional synonyms rules to replace the process.env if in is in global or globalThis

The following strings should be replaced

process.env.foo // ({}).foo
global.process.env.foo // ({}).foo
globalThis.process.env.foo // ({}).foo

The following strings should NOT be replaced

someVar.process.env.foo
someVar.global.process.env.foo
someVar.globalThis.process.env.foo

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 7, 2021
@antfu antfu changed the title Doesn't replacing process.env if process not global variable fix: don't replace process.env if process not global variable Jun 8, 2021
@antfu antfu merged commit 5aeadb7 into vitejs:main Jun 8, 2021
@cawa-93 cawa-93 deleted the patch-1 branch June 8, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected token if object contains process.env

4 participants