fix: don't replace process.env if process not global variable#3703
Merged
antfu merged 4 commits intovitejs:mainfrom Jun 8, 2021
cawa-93:patch-1
Merged
fix: don't replace process.env if process not global variable#3703antfu merged 4 commits intovitejs:mainfrom cawa-93:patch-1
process.env if process not global variable#3703antfu merged 4 commits intovitejs:mainfrom
cawa-93:patch-1
Conversation
nihalgonsalves
approved these changes
Jun 7, 2021
Shinigami92
approved these changes
Jun 7, 2021
process.env if process not global variableprocess.env if process not global variable
9 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try to fix #3701
Additional context
replacementswill not be replaced if the.(dot) goes before it.process.envif in is inglobalorglobalThisThe following strings should be replaced
The following strings should NOT be replaced
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).