fix: surface exception when failing to resolve package entry#4426
Merged
patak-cat merged 1 commit intovitejs:mainfrom Aug 16, 2021
Merged
fix: surface exception when failing to resolve package entry#4426patak-cat merged 1 commit intovitejs:mainfrom
patak-cat merged 1 commit intovitejs:mainfrom
Conversation
benmccann
force-pushed
the
surface-exception
branch
from
78c16da to
cc2f616
Compare
patak-cat
previously approved these changes
Jul 29, 2021
Shinigami92
reviewed
Jul 29, 2021
Shinigami92
added
the
p3-minor-bug
benmccann
force-pushed
the
surface-exception
branch
from
aa30a57 to
8792e0b
Compare
Shinigami92
approved these changes
Aug 13, 2021
patak-cat
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolveExportsthrows an exception when trying to SSR Firebase. This method had aFailed to resolve entry for packageerror message, but it wouldn't get triggered if there's an exceptionAdditional context
Firebase has long been the #1 library that people complain about using with SvelteKit. I finally got tired of people complaining about it and decided to dig into it. It turns out that there was an exception being thrown and swallowed. This will allow some details to be printed to the console to reveal what the issue is (#4425)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).