feat: legacy options to revert to v2 strategies#8623
Merged
Conversation
patak-cat
changed the title
bluwy
reviewed
Jun 17, 2022
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Looks like we might need new docs for the experimental options. And also, perhaps we should deprecate build.commonjsOptions too?
Member
|
|
patak-cat
changed the title
Member
Author
|
Thanks @antfu, |
sapphi-red
reviewed
Jun 17, 2022
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
reviewed
Jun 17, 2022
Co-authored-by: 翠 / green <green@sapphi.red>
9 tasks
sapphi-red
previously approved these changes
Jun 17, 2022
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
One typo and diff is including #8592 for some reason but LGTM
Co-authored-by: 翠 / green <green@sapphi.red>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new options marked as experimental and deprecated to revert to v2 strategies, and express clear intent that these may be removed in a v3 minor
legacy.devDepsScannerlegacy.buildRollupPluginCommonjslegacy.buildSsrCjsExternalHeuristicsWhat is the purpose of this pull request?