feat: worker config call config hook#9212
Merged
patak-dev merged 6 commits intovitejs:mainfrom Jul 19, 2022
Merged
Conversation
poyoho
commented
Jul 19, 2022
Comment on lines
+610
to
+614
| const resolvedWorkerOptions: ResolveWorkerOptions = { | ||
| format: workerConfig.worker?.format || 'iife', | ||
| plugins: [], | ||
| rollupOptions: workerConfig.worker?.rollupOptions || {} | ||
| } |
Member
Author
There was a problem hiding this comment.
NOTE: the raw userPlugin can not modify the config.worker.
user config config and worker resolved config use the same resolvedWorkerOptions what config by vite.config.js and modify by worker plugin.
patak-dev
approved these changes
Jul 19, 2022
Member
|
Thanks a lot @poyoho, looks good! |
This was referenced Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: #9205
Additional context
call worker config hooks.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).