fix: gracefully ignore unlink errors#9291
Closed
silverwind wants to merge 1 commit intovitejs:mainfrom
Closed
Conversation
97c6868 to
f48ed3e
Compare
f48ed3e to
15dd547
Compare
Member
|
I think this should be fixed in #9224. Are you running builds/dev in parallel? |
Author
|
Yes, it's possible that they run in parallel, so it looks to be a race condition as it does not happen every time. |
Author
|
Linked fix should work, but it could still fail if both files are written in the same millisecond, so I guess that fix here may still be valuable. |
Member
|
I doubt there's a chance both files are writing within the same millisecond. We're running |
Author
|
Okay, I will wait for next release then to verify the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm seeing intermittent build failures relating to deletion of a temporary file
vite.config.js.mjswhich is generated byloadConfigFromBundledFile:I'm not sure why it fails exactly, but I'm sure that these unlink errors can be gracefully ignored, which I did here.
What is the purpose of this pull request?