Force resolve webpack dependency for create-react-app#12270
Closed
dbussink wants to merge 1 commit intovitessio:mainfrom
Closed
Force resolve webpack dependency for create-react-app#12270dbussink wants to merge 1 commit intovitessio:mainfrom
dbussink wants to merge 1 commit intovitessio:mainfrom
Conversation
This includes the override of the upgrade proposed in facebook/create-react-app#12172. I think though that we really should look at moving away from `create-react-app` since PRs like that and other issues show it's not really maintained anymore. We could switch to something like Vite instead but this is a quicker way for now to silence Dependabot. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Contributor
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Contributor
|
This PR was closed because it has been stale for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the override of the upgrade proposed in facebook/create-react-app#12172.
I think though that we really should look at moving away from
create-react-appsince PRs like that and other issues show it's not really maintained anymore.We could switch to something like Vite instead but this is a quicker way for now to silence Dependabot.
Related Issue(s)
Fixes the last Dependabot alert at https://github.com/planetscale/vitess/security/dependabot/8
This doesn't have the issue from #12267 where it looks like the dependency was manually changed in the
package-lock.json.Checklist