fix(browser): add magic-string to optimizeDeps.include#5278
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Mar 14, 2024
Merged
fix(browser): add magic-string to optimizeDeps.include#5278sheremet-va merged 2 commits intovitest-dev:mainfrom
magic-string to optimizeDeps.include#5278sheremet-va merged 2 commits intovitest-dev:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Snapshot update works inside the repository
test/browserbut apparently it fails when installed. I still don't fully understand the intricacy of this difference, but addingvitest > @vitest/snapshot > magic-stringseems to work.I verified manually that this fix the issue by using
pnpm patchin a reproduction:https://github.com/hi-ogawa/reproductions/tree/main/vitest-5263-browser-snapshot
One thing I found is that, when running tests from
test/browser, I see a few logsvite:deps new dependencies found: ...and there was previouslymagic-stringin there, but it's now gone. There are a few more dependencies like that, so they might also cause some issues depending of usage?Show logs with DEBUG=vite:deps
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.