Skip to content

fix(coverage): prevent reportsDirectory from removing user's project#5376

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
AriPerkkio:fix/prevent-removing-cwd-dir
Mar 14, 2024
Merged

fix(coverage): prevent reportsDirectory from removing user's project#5376
sheremet-va merged 1 commit intovitest-dev:mainfrom
AriPerkkio:fix/prevent-removing-cwd-dir

Conversation

@AriPerkkio
Copy link
Member

Description

Configuration below can remove user's whole project including local Git history from .git. One could accidentally use that when trying to generate coverage reports in the root of project instead of the default ./coverage, and find out that their whole project is now wiped (that's me 🙃).

Details
// Don't run this
export default defineConfig({
  test: {
    coverage: {
      reportsDirectory: './',
    },
  },
})

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants