fix(coverage): thresholds to compare files relative to root#5574
Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom Apr 22, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In following project:
... users no longer need to define
**/src/utils.tsincoverage.thresholds[<glob>]. A simplesrc/utils.tsworks now.import { defineConfig } from "vitest/config"; export default defineConfig({ test: { coverage: { thresholds: { - '**/src/utils.ts': { + 'src/utils.ts': { functions: 100, }, }, }, }, });Documentation is already using this pattern:
vitest/docs/config/index.md
Lines 1322 to 1328 in 413ec5e
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.