feat(cli): Extend existing list command to output only a list of file names#6392
Merged
sheremet-va merged 18 commits intovitest-dev:mainfrom Aug 29, 2024
Merged
feat(cli): Extend existing list command to output only a list of file names#6392sheremet-va merged 18 commits intovitest-dev:mainfrom
sheremet-va merged 18 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Aug 26, 2024
Member
sheremet-va
left a comment
There was a problem hiding this comment.
This implementation seems a bit pointless because you can do the same yourself on vitest list result.
What we need is to not collect tests at all to make this very fast. This line should just not be called:
vitest/packages/vitest/src/node/core.ts
Line 369 in 95f0203
Contributor
Author
|
OK, async listFiles(filters?: string[]) {
const files = await this.filterTestsBySource(
await this.globTestFiles(filters),
)
return files
}in the vitest class and checking the option in cac.ts:collect() and calling it will do the job ? |
sheremet-va
requested changes
Aug 26, 2024
sheremet-va
requested changes
Aug 27, 2024
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
sheremet-va
requested changes
Aug 27, 2024
Ma-hawaj
commented
Aug 27, 2024
sheremet-va
reviewed
Aug 27, 2024
sheremet-va
approved these changes
Aug 29, 2024
Member
|
Thanks! |
This was referenced Oct 5, 2024
This was referenced Oct 24, 2024
This was referenced Oct 25, 2024
This was referenced Oct 28, 2024
This was referenced Oct 30, 2024
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend existing list command to output only a list of file names
closes #6374
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
introduces breaking changes without a discussion, PR might be closed.
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.