Skip to content

docs: warn that artifacts may have empty attachments#9605

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
macarie:docs/empty-artifact-attachments
Feb 7, 2026
Merged

docs: warn that artifacts may have empty attachments#9605
sheremet-va merged 1 commit intovitest-dev:mainfrom
macarie:docs/empty-artifact-attachments

Conversation

@macarie
Copy link
Member

@macarie macarie commented Feb 7, 2026

Description

Since #9350, artifacts' attachments can get removed. Better document this behavior (because I got hit by it while working on #9588) and fix the example, as it would introduce bugs at runtime 😛

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@macarie macarie requested a review from sheremet-va February 7, 2026 00:54
@netlify
Copy link

netlify bot commented Feb 7, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a09e027
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69868d4d059e290008d3754a
😎 Deploy Preview https://deploy-preview-9605--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit 9cb80c0 into vitest-dev:main Feb 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants