feat:support set pod recoverypolicy in podset when pod fails

[erictanjn]

Pull Request Description

In our scenario, suppose we use pp2 (2*8 GPUs) to deploy the model. If a pod in the podset fails, the default RecoveryPolicy is ReplaceUnhealthy, which only restarts the failed pod. However, the underlying mechanism of the podset already supports Recreate. I want to enable this configuration, which can also be set using stormservice, so that when a pod in the podset fails, all pods are restarted.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the orchestration capabilities by introducing a configurable pod recovery policy for podsets. This allows for more flexible handling of pod failures, particularly in scenarios requiring all pods in a set to be restarted (recreated) rather than just the unhealthy ones, which is crucial for maintaining the integrity of distributed workloads like those using multiple GPUs.

Highlights

• Pod Recovery Policy: Introduced a new PodRecoveryPolicy field within the RoleSpec to allow users to define how pods in a podset are recreated upon failure. This policy can be set to ReplaceUnhealthy (default) or Recreate.
• PodSet Creation: Modified the PodSetRoleSyncer to pass the newly defined PodRecoveryPolicy from the RoleSpec directly to the PodSet during its creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new PodRecoveryPolicy field to the RoleSpec in api/orchestration/v1alpha1/roleset_types.go, allowing users to define how pods are recreated upon failure. This policy is then integrated into the PodSet creation logic in pkg/controller/roleset/podset_rollsyncer.go. A review comment suggests improving the documentation for PodRecoveryPolicy to explicitly state that it is only effective when PodGroupSize > 1 to enhance API clarity and prevent user confusion.

[gemini-code-assist]

For better API clarity, the comment should mention that PodRecoveryPolicy is only effective when PodGroupSize > 1. This will help users understand the condition under which this policy applies and prevent potential confusion when they use roles with single pods.

Suggested change

	// PodRecoveryPolicy defines how pods in the pod sets are recreated when pod failures happen.
	// PodRecoveryPolicy defines how pods in the pod sets are recreated when pod failures happen. This policy is only effective when PodGroupSize > 1.