[BugFix] [KVConnector] Fix KV events for LMCache connector - #32169
Merged
Conversation
LMCache does not yet support `lora_name` as an events property. This PR fixes the LMcache connector for now until the property is supported. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a critical AttributeError that occurs when using the LMCache connector with KV events enabled, due to the lora_name property not being available in the current version of LMCache. The fix correctly resolves the crash by setting lora_name to None. I've provided one suggestion to make the fix more robust and future-proof by using getattr, which will automatically adapt when LMCache adds support for lora_name in a future release.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
NickLucche
enabled auto-merge (squash)
January 13, 2026 14:04
simon-mo
pushed a commit
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
sammysun0711
pushed a commit
to sammysun0711/vllm
that referenced
this pull request
Jan 16, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…ect#32169) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A small fix for the LMCache connector as LMCache does not yet support
lora_nameas an events property. Bug introduced in #27577.The error occurs when try to prompt a model with LMCache connector and KV events enabled:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Note
Prevents crashes when using LMCache KV events by aligning with current LMCache event schema.
lmcache_connector.py, setlora_name=Nonewhen creatingBlockStoredfrom LMCache events (LMCache does not providelora_nameyet).Written by Cursor Bugbot for commit 609dec1. This will update automatically on new commits. Configure here.
Note
Prevents crashes when LMCache KV events omit
lora_name.lmcache_connector.py, constructBlockStoredwithlora_name=getattr(e, "lora_name", None)to align with current LMCache event schema and maintain compatibilityWritten by Cursor Bugbot for commit ecaab07. This will update automatically on new commits. Configure here.
Note
Cursor Bugbot is generating a summary for commit 0233a46. Configure here.
Note
Fixes LMCache KV events compatibility by making
lora_nameoptional when constructingBlockStored.lmcache_connector.py, setlora_name=getattr(e, "lora_name", None)to align with LMCache events that omitlora_name, preventing AttributeError crashes during KV event processingWritten by Cursor Bugbot for commit 0233a46. This will update automatically on new commits. Configure here.