[KVConnector] Remove redundant method KVConnectorOutput::merge() - #38546
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
hickeyma
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the merge method from the KVConnectorOutput class in vllm/v1/outputs.py. The review feedback suggests that the _combine_non_none helper function should also be removed, as it likely becomes unused after the deletion of the merge method.
I am having trouble creating individual review comments. Click here to see my feedback.
vllm/v1/outputs.py (170-206)
With the removal of this merge method, the helper function _combine_non_none (defined from line 131) appears to be no longer used. To improve maintainability, please consider removing it as part of this pull request.
hickeyma
changed the title
Function calling was removed in vllm-project#37013 Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
hickeyma
force-pushed
the
rem-redundant-merge-func
branch
from
March 30, 2026 12:59
5afe66d to
38b7cac
Compare
Collaborator
|
@fynnsu Any objections on this one? |
Contributor
orozery
approved these changes
Mar 30, 2026
neweyes
pushed a commit
to neweyes/vllm
that referenced
this pull request
Mar 31, 2026
…m-project#38546) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Signed-off-by: neweyes <328719365@qq.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
…m-project#38546) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…m-project#38546) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…m-project#38546) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…m-project#38546) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
merge()method calling was removed in #37013 and as its no longer used then it better to remove this function for maintainability purposes.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.