Skip to content

fix(security): block request-level GPU video backend selection withou… - #47259

Merged
vllm-bot merged 4 commits into
vllm-project:mainfrom
jperezdealgaba:fix/pynvvideocodec-vram-bypass
Jul 6, 2026
Merged

fix(security): block request-level GPU video backend selection withou…#47259
vllm-bot merged 4 commits into
vllm-project:mainfrom
jperezdealgaba:fix/pynvvideocodec-vram-bypass

Conversation

@jperezdealgaba

Copy link
Copy Markdown
Contributor

Prevent request-level media_io_kwargs from selecting GPU video backends (e.g. pynvvideocodec) when the engine did not reserve VRAM for them at startup. VideoMediaIO.merge_kwargs() now strips GPU backend overrides from runtime kwargs unless the static config already named that backend, closing a resource exhaustion vector where unreserved CUDA context and decoder-surface allocations could starve the KV cache.

…t VRAM reservation

Prevent request-level media_io_kwargs from selecting GPU video backends
(e.g. pynvvideocodec) when the engine did not reserve VRAM for them at
startup. VideoMediaIO.merge_kwargs() now strips GPU backend overrides
from runtime kwargs unless the static config already named that backend,
closing a resource exhaustion vector where unreserved CUDA context and
decoder-surface allocations could starve the KV cache.
Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>

Signed-off-by: jperezde <jperezde@redhat.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the multi-modality Related to multi-modality (#4194) label Jul 1, 2026
@DarkLight1337
DarkLight1337 requested a review from Isotr0py July 1, 2026 07:54

@Isotr0py Isotr0py left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isotr0py
Isotr0py enabled auto-merge (squash) July 1, 2026 08:00
Comment thread vllm/multimodal/video.py Outdated
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 1, 2026
Add a `requires_gpu` parameter to VIDEO_LOADER_REGISTRY.register() so
backends self-declare their GPU requirements at registration time instead
of being tracked in a separate frozenset. This keeps the metadata
co-located with the registration and makes it trivial for future GPU
backends to opt in.
Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>

Signed-off-by: jperezde <jperezde@redhat.com>
auto-merge was automatically disabled July 2, 2026 08:16

Head branch was pushed to by a user without write access

@jperezdealgaba
jperezdealgaba requested a review from njhill as a code owner July 2, 2026 08:16
@mergify mergify Bot added the v1 label Jul 2, 2026
Comment thread vllm/multimodal/media/video.py Outdated

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

jperezdealgaba and others added 2 commits July 3, 2026 10:56
Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>

Signed-off-by: jperezde <jperezde@redhat.com>
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) July 3, 2026 09:03
@jperezdealgaba

Copy link
Copy Markdown
Contributor Author

The error doens't seem to be caused by my changes

@khluu

khluu commented Jul 6, 2026

Copy link
Copy Markdown
Member

merged!

@vllm-bot
vllm-bot merged commit ba22152 into vllm-project:main Jul 6, 2026
90 of 92 checks passed
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Jul 15, 2026
vllm-project#47259)

Signed-off-by: jperezde <jperezde@redhat.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
vllm-project#47259)

Signed-off-by: jperezde <jperezde@redhat.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants